Skip to content

Use a quasi-unique group name in this e2e test. #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
3405691582 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use a quasi-unique group name in this e2e test. #1983

3405691582 wants to merge 1 commit into from
+2 −1

Conversation

@3405691582
Copy link
Collaborator

@3405691582 3405691582 commented Jan 8, 2026

I suspect there may be either some lack of cleanup or race that occurs when executing the tests, since the error mentions "An instance group already exists with name: cvd". I don't want to plumb too deeply into figuring out exactly why this happens; instead, just generate a quasi-unique group name based on the time and this way they should likely not collide any more.

@3405691582 3405691582 requested a review from ser-io January 8, 2026 16:13
@3405691582
Use a quasi-unique group name in this e2e test.
185389b 
I suspect there may be either some lack of cleanup or race that occurs
when executing the tests, since the error mentions "An instance group
already exists with name: cvd". I don't want to plumb too deeply
into figuring out exactly why this happens; instead, just generate
a quasi-unique group name based on the time and this way they should
likely not collide any more.
ser-io
ser-io requested changes Jan 8, 2026
View reviewed changes
Copy link
Member

@ser-io ser-io left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fail if there's a cvd instance already created when the tests is about to run. The e2e test creating instances were implemented to be run in clean containers https://github.com/google/android-cuttlefish/blob/main/.github/actions/run-cw-sharded-e2e-test/action.yaml#L72 each of them.

@ser-io
Copy link
Member

ser-io commented Jan 9, 2026

Explaining the group name collision error:

When flaky = True was added to snapshot_test_test bazel rule in #1934. Bazel started attempting the same test 3 times, as the test is known to be flaky, when the first attempt fails due the flakiness of cvd suspend with error: cvd suspend failed: execution of "/usr/bin/cvd" command with args ["/usr/bin/cvd" "--group_name=cvd" "--instance_name=1" "suspend"] failed: exit status 255, the next two attempt would fail in a deterministic way with error: An instance group already exists with name: cvd because the group was already taken in the first attempt and the test is meant to be run in a brand new environment every time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ser-io ser-io ser-io requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@3405691582 @ser-io